[Packaging] Fix #24788: Add -I in entrypoint on MacOS
#24796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
Collaborator
|
Packaging |
Member
|
I happen to have a PR to refine the help message for |
jiasli
approved these changes
Jan 31, 2023
Member
|
Very clear PR description! |
3 tasks
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #24788.
azstart withpython -mand-madds the current directory to the start ofsys.path.In #24788, if the working dir has a
brotlifolder,urllib3will import it and lead to error.https://github.com/urllib3/urllib3/blob/0612a53f48f72ab6e9ef58ccf1d6a25b847152fc/src/urllib3/response.py#L17-L23
To remove current dir from path,
-Iis needed.-Ihas already been added in entrypoint on Linux and Windows, this PR adds it on MacOS.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.